parquet-java icon indicating copy to clipboard operation
parquet-java copied to clipboard
verified publisher icon apache

PARQUET-1573: Add a docker development image and use it in travis

Open iemejia opened this issue 6 years ago • 7 comments

Enable travis cache for .m2 directories and the build docker image to boost speed too.

iemejia avatar May 14 '19 16:05 iemejia

Pushed requested changes and rebased. Please tell me if you see any other things I can improve. I will do a subsequent PR after to change the IT behavior I mentioned.

iemejia avatar May 27 '19 12:05 iemejia

Any other comments can this get merged?

iemejia avatar May 29 '19 09:05 iemejia

pinging again, maybe @zivanfi ?

iemejia avatar Jun 12 '19 09:06 iemejia

I'm not too familiar with docker, @gszadovszky maybe?

zivanfi avatar Jun 12 '19 10:06 zivanfi

Yes that was 'intended' because it made way more complex the build, I will try to think about a simpler alternative if this is absolutely required, but isn't this already tackled by the fact that Parquet does code review first. Sadly I am quite busy this and the next week but I will come back in 2 weeks.

iemejia avatar Jun 14 '19 08:06 iemejia

Silently removing functionality that was added for a purpose is not good practice. Code reviews are not a substitute for automated checks, similar to how they do not make unit tests unnecessary either.

zivanfi avatar Jun 14 '19 10:06 zivanfi

Agree, anything that we can automatize is better, will fix.

iemejia avatar Jun 14 '19 11:06 iemejia