Yan Xue
Yan Xue
> Could you please alse add cmake targets in `exporters/memory/CMakeLists.txt` and `cmake/opentelemetry-cpp-config.cmake.in` . Sure, I can add that. I feel supporting/maintaining two build systems is a little bit inconvenient. Do...
> > Thanks for the PR @yxue. This is your first PR here, and it is nicely done :) > > Just thinking whether the InMemoryExporter should have any dependency...
Thanks @lalitb @owent and @ThomsonTan for the info about the building system. I am not sure about fixing the gcc 4.8 and grpc compatibility. I do see the building systems...
> > Thanks @lalitb! I was thinking about using the CircularBuffer with the ResourceMetrics but then we need the special process for the pointers inside the structure > > Yes,...
> Could you please revert changes in `/exporters/otlp` ?It's duplicated with #1487 , I belive this PR is just for memory metrics exporter. The change under exporters/otlp is for fixing...
> > LGTM after `in_memory_metric_exporter` is also added into `cmake/opentelemetry-cpp-config.cmake.in`. > > Good point. @yxue this file contains the rules to enable opentelemetry-cpp included in other projects cmake files using...
Do we consider use the tools like https://github.com/google/bazel-to-cmake? The CMakeLists.txt can be generated from the BUILD and WORKSPACE as mentioned.