opentelemetry-cpp icon indicating copy to clipboard operation
opentelemetry-cpp copied to clipboard

Libraries delivered: Reconcile Bazel and CMake build

Open marcalff opened this issue 3 years ago • 4 comments

This is a remaining item identified during review of PR #1420

(1)

Document:

  • the name of each library delivered
  • the expected dependency graph (DAG)

This documentation is meant to be used by:

  • users of opentelemetry-cpp,
  • maintainers of opentelemetry-cpp.

A good place could be docs/library-distribution.md

(2)

Fix the Bazel build to comply with (1)

(3)

Fix the CMake build to comply with (1)

Libraries build with Bazel or CMake should be the same.

marcalff avatar Jun 03 '22 07:06 marcalff

Do we consider use the tools like https://github.com/google/bazel-to-cmake? The CMakeLists.txt can be generated from the BUILD and WORKSPACE as mentioned.

yxue avatar Jul 10 '22 06:07 yxue

I think it's difficult to use bazel-to-cmake like tools. CMake support environment detection better and has a better compatibility then bazel.(e.g. We support gcc 4.8 and use a old version of gRPC and abseil-cpp with cmake, but we don't suport legacy compilers with bazel now). Maybe we can consider If there is a tool than can convert cmake script to bazel script, or just write a script to check if is there any target name different between bazel and cmake?

owent avatar Jul 11 '22 02:07 owent

This issue was marked as stale due to lack of activity.

github-actions[bot] avatar Sep 10 '22 02:09 github-actions[bot]