Yusuke Wada comments

Results 1706 comments of


                                            Yusuke Wada

feat(secureHeader): add Permissions-Policy header to secure headers middleware

@kbkn3 Thank you! Let's go with it. This is a new feature so that it will be included in the next new minor version, `v4.6.0`. I'll later merge this PR...

feat(context): Custom header name for c.header

Hi @akku1139 Supporting adding extra header names is good. But I don't agree with using the generics for `Hono`. The generics for `Hono` have two types, `Bindings` and `Variables`. These...

feat(context): Custom header name for c.header

Regarding adding custom header types, I think it's not good to pass generics to `new Hono` because of [the above reason](https://github.com/honojs/hono/pull/3289#issuecomment-2295208742). Instead of it, we can extend the types with...

chore(test): migrate to vitest v2

@yasuaki640 Thank you!! Let's go with it.

feat(client): improve handling status code types

Hey @m-shaka @NamesMT Can you share your opinion on this PR and review it?

feat(client): improve handling status code types

@m-shaka @NamesMT Thank you! As you said, we should support the default response type. I like @NamesMT 's implementation. My proposal is to pass the default type generics into `client.foo.$ge()`...

feat(client): improve handling status code types

@m-shaka Thank you for your comment! @NamesMT What do you think of this API? https://github.com/honojs/hono/pull/3292#issuecomment-2295778823

feat(client): improve handling status code types

Hi @NamesMT It looks good! We should consider the naming if we go with `$withDR` or get other names, but I like the idea (I think `withDR` is not bad).

feat(client): improve handling status code types

@NamesMT Okay! Enjoy your time!

The serverStatic() of Cloudflare pages not works

Hi @Scythemen Can you share a minimal project to reproduce it?