Yusuke Wada comments

Results 1706 comments of


                                            Yusuke Wada

Cloudflare worker app's export

Hi @ruanyf That code should work correctly. Maybe it's not a bug.

[@hono/auth-js] Callbacks from oauth providers are not registered

@pwalczyszyn What is the behavior if you run it on Wrangler, not Cloudflare + Vite + Hono?

c.req.valid() showing some errors when using validator module in a route

Hi @szabbbbu You should return the actual values having expected types in the validator: ```ts app .get('someroute', (c) => { return c.json({}) }) .post( validator('form', (value, c) => { return...

fix: Read all chunks when hashing a readable stream

Hi @jpdutoit Thank you for the PR! Can you write a unit test in `src/utils/crypto.test.ts`?

feat(jsx): improve form attribute types

@ssssota Thank you for the PR! I didn't know `dialog` for the value of the form `method`! I'll merge it now.

Non-streaming ErrorBoundary in streaming context

Hi @Mabi19 > I could probably contribute this to the documentation if you want. Please! Thank you.

Non-streaming ErrorBoundary in streaming context

Hi @Mabi19 @usualoma > @yusukebe Do you think we should add such a function? I think it's fine. However, I'm wondering if it's good or not to wait for an...

feat(secureHeader): add Permissions-Policy header to secure headers middleware

Hi @kbkn3 Thank you for the PR! @watany-dev Can you review this?

feat(secureHeader): add Permissions-Policy header to secure headers middleware

@watany-dev Thank you for reviewing. @kbkn3 Can you take a look?

feat(secureHeader): add Permissions-Policy header to secure headers middleware

@watany-dev Thank you for reviewing!! @kbkn3 Last one thing. Can you run `bun run format:fix && bun run lint:fix` to format the code?