Yusuke Wada comments

Results 1706 comments of


                                            Yusuke Wada

zValidator types not working with rpc client query

Hi @wststone @cybercoder-naj The Zod Validator uses `z.input` to infer a query using the request type. With it, the value with `z.coerce` will have `undefined` and optional: ![CleanShot 2024-09-10 at...

zValidator types not working with rpc client query

Hi @ambergristle I'm not sure what the problem 100%, but the `page` in the client being `string` is correct behavior because it is already "string" in the client request.

zValidator types not working with rpc client query

> do you mean that the client types `param` and `query` values as `string` because they have to be converted to strings when making the request? Yes, yes!

make fetch Response headers mutable

Hi @nitedani @usualoma Sorry for the delayed response. This will be awesome PR! Sometimes, I have trouble with a matter like #3316 when I `fetch` origin content and return it...

make fetch Response headers mutable

Hi @nitedani Can you work on this? If you can't, I'll do it.

make fetch Response headers mutable

Hi @usualoma I've updated [the @nitedani 's branch](https://github.com/nitedani/hono/tree/nitedani/immutable-headerse) with applying your patch and pushing it. The test passed on my machine, but the CI is falling. Do you have any...

make fetch Response headers mutable

@usualoma Cooool! It passed. Can you review this again, though it should be okay?

getConnInfo Cannot destructure property 'remoteAddr' of 'c.env' as it is undefined.

Hi @winston0410 As @EdamAme-x said, please use `Deno.serve()` instead of `export default app`: ```ts Deno.serve(app.fetch) ``` The starter template and the website was using `export default app`, but as you...

getConnInfo Cannot destructure property 'remoteAddr' of 'c.env' as it is undefined.

Closing this issue since there is no response. Thanks.

Feature Req: Otel middleware

Hi @DawnImpulse There is no update. We (at least I) don't plan to create it right now, so I hope someone works on it.