Yujia Qiao

Results 128 comments of Yujia Qiao

Yes. the TODO in the source is not very accurate. I'm also thinking of multi-process programs calling fork etc. Still not sure how to handle those cases, especially when threads...

Thanks for your interest! I took a quick look at your contribution. Good Job. I've been thinking about adding i18n support for a long time but failed to find time...

Sorry for the delay! I've forgotten this stuff 🤡🤡🤡 Your PR looks good and need a little improvement as pointed out.

I see the fix of https://github.com/rapiz1/DungeonRush/issues/28 is still in this PR. Can you cherry-pick that and open a separate PR? If you don't have time, I can do that :)

behaved weird on my machine (archlinux) chooseLanguageUi ![image](https://user-images.githubusercontent.com/20105061/149731187-dc064fd6-f50c-4b4a-91cb-a2d52b0c0e4d.png) After set to the second option (simplified chinese maybe?) ![image](https://user-images.githubusercontent.com/20105061/149731299-92f9b663-f5f0-41fc-a14c-1ab5da7358ff.png) In gameplay ![image](https://user-images.githubusercontent.com/20105061/149731311-492fb2c1-40d0-4f4e-8e1b-cd6a12688408.png) Scoreboard ![image](https://user-images.githubusercontent.com/20105061/149731372-a8865be5-fdc5-4699-8dd4-6c03c9e65a93.png)

Thanks for playing! I suggest investigating function gameLoop. Not far from main. ---Original--- From: "Giovanni ***@***.***> Date: Sun, Aug 29, 2021 18:54 PM To: ***@***.***>; Cc: ***@***.***>; Subject: [rapiz1/DungeonRush] Feature:...

Thanks for your feedback! I will consider adding a coop mode in the next release as long as I get the time to get back on this. Also, note that...

Thanks. I won't add this binary to the release page for security reasons. But I will leave this issue open for anyone who wants to refer to until an official...

I have tried complete -Cnsl and found duplicated entries. Maybe it's a issue of fish.

However, fish's native completion does not have this problem. It looks like fish has somehow remove the duplicates.