DungeonRush icon indicating copy to clipboard operation
DungeonRush copied to clipboard

Chinese Version

Open Haceau-Zoac opened this issue 5 years ago β€’ 7 comments

A little contribution :)

Haceau-Zoac avatar Nov 07 '20 15:11 Haceau-Zoac

Thanks for your interest!

I took a quick look at your contribution. Good Job.

I've been thinking about adding i18n support for a long time but failed to find time to do that. And you're going in the right direction by replacing hardcoded text with text from loaded files.

And here are some feedbacks:

  • There are some refactoring not related to i18n support. Please place them in a separate PR.

  • It may be better to rename the language option to 'Languages'/'η•Œι’θ―­θ¨€'

BTW, I've seen some mistakes in your translation. Are you using a web translator? I would say it's not very satisfying. Maybe there are some words misspelled in the original README.

I don't have much time for the review because of the upcoming exams. So my reply maybe delayed. Thanks.

yujqiao avatar Nov 15 '20 10:11 yujqiao

Thanks for your interest!

I took a quick look at your contribution. Good Job.

I've been thinking about adding i18n support for a long time but failed to find time to do that. And you're going in the right direction by replacing hardcoded text with text from loaded files.

And here are some feedbacks:

  • There are some refactoring not related to i18n support. Please place them in a separate PR.
  • It may be better to rename the language option to 'Languages'/'η•Œι’θ―­θ¨€'

BTW, I've seen some mistakes in your translation. Are you using a web translator? I would say it's not very satisfying. Maybe there are some words misspelled in the original README.

I don't have much time for the review because of the upcoming exams. So my reply maybe delayed. Thanks.

Yes, I am using a web translator, plus a little bit of my own understanding.

And can the feedbacks be more detailed?

Thanks.

Haceau-Zoac avatar Nov 15 '20 10:11 Haceau-Zoac

Sorry for the delay! I've forgotten this stuff 🀑🀑🀑 Your PR looks good and need a little improvement as pointed out.

yujqiao avatar Jan 05 '22 03:01 yujqiao

I see the fix of https://github.com/rapiz1/DungeonRush/issues/28 is still in this PR. Can you cherry-pick that and open a separate PR? If you don't have time, I can do that :)

yujqiao avatar Jan 05 '22 03:01 yujqiao

OK

Haceau-Zoac avatar Jan 08 '22 11:01 Haceau-Zoac

behaved weird on my machine (archlinux)

chooseLanguageUi image

After set to the second option (simplified chinese maybe?) image

In gameplay image

Scoreboard image

yujqiao avatar Jan 17 '22 08:01 yujqiao

behaved weird on my machine (archlinux)

chooseLanguageUi image

After set to the second option (simplified chinese maybe?) image

In gameplay image

Scoreboard image

I merged new commits in this repo but I'm not test it.

Haceau-Zoac avatar Jan 17 '22 08:01 Haceau-Zoac