Chinese Version
A little contribution :)
Thanks for your interest!
I took a quick look at your contribution. Good Job.
I've been thinking about adding i18n support for a long time but failed to find time to do that. And you're going in the right direction by replacing hardcoded text with text from loaded files.
And here are some feedbacks:
-
There are some refactoring not related to i18n support. Please place them in a separate PR.
-
It may be better to rename the language option to 'Languages'/'ηι’θ―θ¨'
BTW, I've seen some mistakes in your translation. Are you using a web translator? I would say it's not very satisfying. Maybe there are some words misspelled in the original README.
I don't have much time for the review because of the upcoming exams. So my reply maybe delayed. Thanks.
Thanks for your interest!
I took a quick look at your contribution. Good Job.
I've been thinking about adding i18n support for a long time but failed to find time to do that. And you're going in the right direction by replacing hardcoded text with text from loaded files.
And here are some feedbacks:
- There are some refactoring not related to i18n support. Please place them in a separate PR.
- It may be better to rename the language option to 'Languages'/'ηι’θ―θ¨'
BTW, I've seen some mistakes in your translation. Are you using a web translator? I would say it's not very satisfying. Maybe there are some words misspelled in the original README.
I don't have much time for the review because of the upcoming exams. So my reply maybe delayed. Thanks.
Yes, I am using a web translator, plus a little bit of my own understanding.
And can the feedbacks be more detailed?
Thanks.
Sorry for the delay! I've forgotten this stuff π€‘π€‘π€‘ Your PR looks good and need a little improvement as pointed out.
I see the fix of https://github.com/rapiz1/DungeonRush/issues/28 is still in this PR. Can you cherry-pick that and open a separate PR? If you don't have time, I can do that :)
OK
behaved weird on my machine (archlinux)
chooseLanguageUi

After set to the second option (simplified chinese maybe?)

In gameplay

Scoreboard

behaved weird on my machine (archlinux)
chooseLanguageUi
After set to the second option (simplified chinese maybe?)
In gameplay
Scoreboard
I merged new commits in this repo but I'm not test it.