Yash Thakur

Results 101 comments of Yash Thakur

Both Java and C++ have constructors to create empty trajectories. Is there a legitimate use for them?

Java doesn't segfault, but yeah, it'd be helpful there too. I'll wait to see if there's a legitimate use for empty states before committing, because there are no-arg constructors in...

@calcmogul Our team's had this for a while, but I'm not actually sure why it was originally made. We were having brownouts last month and an alum mentioned that maybe...

@Oblarg A `calculate` method makes more sense, but now that I'm moving the resistance stuff into `PowerDistribution` itself, there are two options for updating the resistance: - Having a `calculate`...

@calcmogul Would it be better to let the user configure the `Notifier` period (with a default of 0.02 s) or just have it set to 0.02 for everyone?

@Oblarg It kinda already makes sure voltage is nonzero before reporting infinity. If both voltage and current are 0, it returns NaN. If only voltage is 0, it returns 0....

@sciencewhiz My team will try looking at that at our next meeting. If it isn't useful, it'd certainly make it much easier to implement, although it'd be less great when...

@Oblarg If someone needs per-channel resistance, the documentation could perhaps advise them to make their own `ResistanceCalculator` and use that with the PDP voltage minus the voltage their motor controller...

Could someone trigger the last test (and/or make sure there's nothing left to be fixed)?

Ah, didn't see that, should be fine now.