David Kim

Results 19 comments of David Kim

Thanks for the PR. But it needs to be rebased. The latest version has supported Swift 4.0. I have not tested with Swift 4.1. I suppose it should be OK.

The 8080 port number is not used by XWebView. You need to check other frameworks which are using by your app. Regarding the HTTP header, see [CROS](https://developer.mozilla.org/en-US/docs/Web/HTTP/CORS) for details.

Sorry for reply late. The http server is intent to be transparent to embedders by design. However, I can be convinced if you have a reasonable case that indeed requires...

All these items are welcome. For item 2, the README had had a quick guide section. It was moved to project wiki. I hope I can write more documents in...

Also, please use [`#if swift(>=4.2)` and `#endif`](https://docs.swift.org/swift-book/ReferenceManual/Statements.html#grammar_compiler-control-statement) to enclose the swift 4.2 specific changes.

> regarding test cases, I think instead of comparing JSON as string, it's better to compare them as actual JSON Object because in some cases that the key order changed,...

The travis settings are to test on OSs (iOS and macOS) which are the minimum requirements. Each time you submit a PR, travis CI will start test after several minutes,...

Unfortunately, many test cases failed. The JsonTests.testDictionary case is the problem you said. Others are the core functions of XWebView. I suppose these can pass in your local environment. We...

I'm not quite understand your question. You can manually compose a javascript expression and evaluate it. ``` let str = "callbackWithData" let exp = str + "(" + toJSON(data) +...