xennex22

`GetASCIIResponseCode` search all of the rx buffer for keywords like OK, ERROR etc. If the data arrives line by line this is ok. If the data arrives all at once...

`Wifi_Wait` uses `osEventFlagsWait` to wait for input. The flags are set in `AT_Notify` based on the received data. The problem I have is that if there is a timeout in...

Improvements to buffer handling (ESP32)

1

I've noticed that the way data is transferred from the serial buffer to the final user buffer is fairly fragile. It is hard to balance the wifi thread (reading and...

ESP32 ARM_WIFI_Initialize callback parameter not checked for NULL

1

`ARM_WIFI_Initialize` takes a callback parameter `cb_event`. This is only used for `ARM_WIFI_EVENT_AP_CONNECT` and `ARM_WIFI_EVENT_AP_DISCONNECT`. According to help the `cb_event` parameter can be NULL if no callback signals are required, however...

Unused static variable in ReceiveData()

4

There is a static variable `n_prev` in the ESP32 function `ReceiveData` which is assigned but not used for anything. https://github.com/ARM-software/CMSIS-Driver/blob/b2a6e81d3123b7532653c61edbbbda7c3e0d22ac/WiFi/ESP32/ESP32.c#L574 https://github.com/ARM-software/CMSIS-Driver/blob/b2a6e81d3123b7532653c61edbbbda7c3e0d22ac/WiFi/ESP32/ESP32.c#L588-L591