CT Wu comments

Results 30 comments of


                                            CT Wu

feat(src): add retry count and retry timeout

Thanks for the pull request! This feature looks promising. I will accept the pull request if you can add some tests which cover the retrying related logic and update the...

Consider adding map file filter configuration

I am glad to hear that it is helpful! We can add `include` and `exclude` to the options which should be compatible with [Webpack rules](https://webpack.js.org/configuration/module/#ruleexclude), so it will be easier...

.supervisorconfig

+1, it will be really useful.

Create a demo page

We can use https://github.com/facebookincubator/create-react-app now

Observable Config for RxjsV6.x

I've created [a PR]( https://github.com/acdlite/recompose/pull/660) for it.

[RFC] Switch mapPropsOnScroll to withWindowScroll

Actually, not. I think we should refactor some of `withXXX`s to `mapPropsOnXXX`s. To implement a `withXXX`, we have to be opinionated on two things: 1. The name of the prop...

Add link to a HOCs criticism

> Additionally, the composition model here is dynamic! ... Probably something we can do with `withState`, `mapProps` and `branch`.

Key advantages in Docs

Indeed, some parts of Recompose’s advantages can be replaced by React hooks.

Key advantages in Docs

Considering state management, hooks are simpler (and faster?).

[RFC] Bump version number to 1.0 (or 27.0.0)

I agree with that we should bump the version to 1.0. The potential blockers probably are #609 and #660.