wilberforce comments

Results 9 comments of


                                            wilberforce

Update tools: Vite - hot reloads, production rollup

@mdo @XhmikosR Have you had a chance to try out this build using vite?

Saving during typing, and before closing window?

@maximelebreton on the window close event - `storage.save(); `

noUse of eval is strongly discouraged

Hi, untested - however this will do it I think! ``` const [dataMin, dataMax] = extent(Array.from(new Set(values.concat([valueMin || 0, valueMax || 0])))) function yMin() { return `${domain[0]}` } function yMax...

import/require natively available packages

Not sure how to handle Native modules like wifi. For modules like MQTT you should be able to copy the module source into the src folder.

import/require natively available packages

webpack *noob* here. Where would that line go? Wouldn't this end up as part of the build?

import/require natively available packages

I have made some progress with this. I'll clean it up and post - perhaps on the forum. I have setup a modules folder - and put the espruino modules...

import/require natively available packages

So this is finding in the modules folder: ``` [ 'DS18B20', 'pid-controller', 'ws', 'www' ] [ './src/modules/DS18B20.js', './src/modules/pid-controller.js', './src/modules/ws.js', './src/modules/www.js' ] ```

Convert PID to ES6 class

Thanks. Please take a look here: I've used getter and setters: https://gist.github.com/wilberforce/88231ea867bc190199c33538c039201f I can merge back into here

Mismatch between legacy constants and setMode()

Yes - it looks like it might be related to this update: https://github.com/wilberforce/pid-controller/commit/9f62aa5e49491ab70ff046b3d64dd826cad79e47 Do you want to update and do a pull request?