code comments

Results 478 comments of


                                            code

Cannot extract response cookie value from Set-Cookie in Header-To-Metadata Filter

> If there is no match or substitution, the header value is used as-is. Sounds it would be better to add a option here. 🤔

Cannot extract response cookie value from Set-Cookie in Header-To-Metadata Filter

`In my personal opinion`, it's just my personal opinion and preference. I personally prefer explicit configuration for different things. Just like the nginx use `upstream_cookie` for response rather than `cookie`...

Cannot extract response cookie value from Set-Cookie in Header-To-Metadata Filter

cc @zuercher

jwt_authn payloadInMetadata not work?

Routing matching is occurring prior to the application of the filter chain. So, because there is no any dynamic metadata when the route entry is matching, so 404 will be...

jwt_authn payloadInMetadata not work?

HTTP requests are processed as follows. ``` 1. route match (no match any route because no dynamic metadata for now). 2. Apply HTTP filter chain. (JWT will be handled and...

jwt_authn payloadInMetadata not work?

For this scene, we need clear the cached route to force envoy to re-match routes. To achieve this, you can write a simple lua script to update HTTP headers and...

subset lb: added multiple keys or multiple selectors support for single host per subset mode

Benchmark result after this PR: ``` ----------------------------------------------------------------------------------- Benchmark Time CPU Iterations ----------------------------------------------------------------------------------- benchmarkSubsetLoadBalancerCreate/0/50 1.88 ms 1.88 ms 352 benchmarkSubsetLoadBalancerCreate/1/50 1.38 ms 1.38 ms 496 benchmarkSubsetLoadBalancerCreate/0/64 2.16 ms 2.16 ms 327...