code

Results 478 comments of code

> if the downstream request do not have those headers, envoy generate a new trace and I don't get those values at all (stream request nor message request) This is...

Looks like this is a general issue for the external grpc requests. But sorry I have no enough bandwidth for this recently. 😞 I will mark this help wanted.

cc @xvzf sorry for the delayed respnose. I almost forget this PR. But I think @nahk-ivanov has given a great explanation about this work. Sorry again for the delay.

> If the behavior of forwarding the request to the upstream if the Origin doesnt not match is acceptable and not a bug, can we introduce a new API field...

It's not easy to provide a feature like this in our core stats system. Dynamic and flexible stats means additional memory, additional complexity. (And I think it's complex enough) But...

A possible path to reach this target: 1. To extend the cluster manager to expose additional method to accept a callback to watch membership change of local cluster. 2. To...

cc @ramaraochavali Global rate limiting introduce additional dependency (rate limit server, redis) and latency, and may not work properly if it's overload. We also use the local limit in the...

> what is the local cluster and how can be used to know the number of replicas? local cluster is a special cluster that contains the Envoy instance self. See...

@ramaraochavali I mean if local rate limit is used, for example, 100 tokens per second is configured, the total limit is 100 * number of Envoy instances. But the instances...

> As I understand, a shared token bucket would (/could) also mean that tokens can be used from a different instance in the local cluster? That would mitigate the problem...