code comments

Results 478 comments of


                                            code

tcp_proxy: fix to make tcp_proxy ON_DOWNSTREAM_TLS_HANDSHAKE mode work without max_early_data_bytes

/wait

Add first-class cookie matcher for HTTP routes (align with proposed Gateway API cookie match)

I think both Envoy Gateway and Istio didn't provide a good support for the xDS matcher for route? It would be better to take the factor into account.

Add first-class cookie matcher for HTTP routes (align with proposed Gateway API cookie match)

@zhaohuabing, yeah, it's could works. But do the Envoy Gateway/Istio now support the generic matcher tree for route?

EP-specific connection pool configuration

Although I agree this may make sense in some specific scenarios, but it also may never be necessary for most users in most of cases. So, all my requirements are...

EP-specific connection pool configuration

> Do you mean like using metadata in the endpoint to set those options? Do we do that with any other type configuration at the moment? Nope. we have no...

EP-specific connection pool configuration

By the way, couldn't make it the hosts (with special protocol setting) as independent cluster? Then we can use other ways to composite these clusters works like single one?

access_log: add OTLP/HTTP exporter to OpenTelemetry access logger

/wait

test: modifying CSWRR integration test xDS setup

LGTM. Thanks.

ext_proc: FULL DUPLEX STREAMED response body truncated when multiple filters defined

When the ext proc Y (the second ext proc filter in your configuration) received the body processing response (this may happens multiples if there are multiple body chunks) from the...

ext_proc: FULL DUPLEX STREAMED response body truncated when multiple filters defined

> "Then problem happens, when HTTP filter chain is recovered from an async calling, if Envoy has received all data from upstream, Envoy will assume the data in the stream...