code
code
This PR involves performance, substitution format, Json serializing, etc. and this PR has lots of technical details and background context. It's not easy to review this PR. Thanks so much...
### The core idea of the new `JsonFormatter`. The core idea of the new `JsonFormatter` is to do as much as possible work when loading configuration. Given a specific `json_format`:...
> Sorry I wanted to finish this review off but I feel like we are still not aligned on converging JSON implementations. np. We all want a best solution. I...
rebase the whole implementation with #35823
Benchmark result if latest string based Streamer is used: ``` ------------------------------------------------------------------------------- Benchmark Time CPU Iterations ------------------------------------------------------------------------------- BM_AccessLogFormatterSetup 7633 ns 7548 ns 93037 BM_AccessLogFormatter 406 ns 404 ns 1683008 BM_StructAccessLogFormatter 6041...
Finally, I back to here.
Cleaned up some comments.
@jmarantz I don't want to put more time repeat what I have did at the code base. But I will try to explain it here. ### Why low level control...
Hi, @zuercher , could you take a look at this when you get some free time. This create a new JSON formatter. You can check the core idea in the...