Viraj Shah
Viraj Shah
I tried it. I just get two empty folders: designs and animations
Bumping the C++ formatting CI version from `v4.11.0 (clang-format-16) -> v4.14.0 (clang-format-19)` should be enough to fix that failing check, though I'm not sure if re-running it after the update...
> If you rerun the checks, it will be fixed. Github tests PRs as if they are merged against main by default. That would make sense, but for whatever reason...
It seems like bumping `pybind11` causes some incompatibility with TensorFlow's usage of `pybind11_absl`. It'll probably take some investigating to figure out.
It's supposed to be an extra diagnostic to catch things like some weights exploding or gradients vanishing. I added it to compare embedding distributions between regular and context nodes.
I have made some newer changes to the way `context_node_mask_` is populated. Previously, only nodes having `NodeType::kInstruction` were ensured to have their corresponding entries in `context_node_mask_` set correctly, as only...
Yes, the expected output matches the fixed list string representation.
> This includes the change in the PR that does the fix. I was mainly asking to confirm that you plan on landing the lower one first. Yeah, ideally I'd...