gematria icon indicating copy to clipboard operation
gematria copied to clipboard

Add support for storing basic block context in Gematria formats.

Open virajbshah opened this issue 1 year ago • 4 comments

  • Add fields to the proto specification to store context.
  • Add members to the Gematria BasicBlock data structure to store context and update methods on it and its Python binding accordingly.
  • Bonus: Remove dangling TODO.

virajbshah avatar Jan 19 '25 22:01 virajbshah

Bumping the C++ formatting CI version from v4.11.0 (clang-format-16) -> v4.14.0 (clang-format-19) should be enough to fix that failing check, though I'm not sure if re-running it after the update will use the new version without adding another commit to this PR.

virajbshah avatar Jan 19 '25 22:01 virajbshah

though I'm not sure if re-running it after the update will use the new version without adding another commit to this PR.

#291. If you rerun the checks, it will be fixed. Github tests PRs as if they are merged against main by default.

boomanaiden154 avatar Jan 29 '25 20:01 boomanaiden154

If you rerun the checks, it will be fixed. Github tests PRs as if they are merged against main by default.

That would make sense, but for whatever reason re-running the action still uses clang-format-18. IIRC, adding another commit to the PR is what gets GitHub to pick up on the updated workflows.

virajbshah avatar Jan 30 '25 10:01 virajbshah

That would make sense, but for whatever reason re-running the action still uses clang-format-18. IIRC, adding another commit to the PR is what gets GitHub to pick up on the updated workflows.

Interesting. Running git merge main on your branch after pulling a recent main should definitely fix the issue.

boomanaiden154 avatar Jan 30 '25 21:01 boomanaiden154