Tengjun Jin
Tengjun Jin
> By the way, do I need to add tests for this? Yes.
Looks good to me. @ddkang
Looks good.
Yes. But can you refactor the code? Don't use three functions.
Can you split the new commit into another PR?
I removed the rows containing NULL values for previous tests. Can you use the data file from the provided link to see if you can reproduce the error? To expedite...
It appears that JSON now allows 'None' values, so this is no longer an issue. However, rows containing 'None' values will be dropped. Could you check if we can remove...
Although there are no errors currently, enhancing the code could help prevent potential problems. The related test is 'test_limit_engine'.
Have you test the performance of Marqo? Here is the results of other vector databases. https://docs.google.com/spreadsheets/d/13ZJCBb2HEdWAjbnXgy55X3hSZHpFKIlsKL9D2jdHvWU/edit?usp=sharing
> > > > Have you test the performance of Marqo? Here is the results of other vector databases. https://docs.google.com/spreadsheets/d/13ZJCBb2HEdWAjbnXgy55X3hSZHpFKIlsKL9D2jdHvWU/edit?usp=sharing > > > > > > > > > Okay,...