aidb icon indicating copy to clipboard operation
aidb copied to clipboard
verified publisher icon ddkang

Limit engine correctness check

Open hjk1030 opened this issue 1 year ago • 6 comments

Resolves issue #54. I assume the problem appears when there are floating point errors during serialization, so I added a function to check the subset relation with floating error tolerance.

hjk1030 avatar May 07 '24 14:05 hjk1030

@ttt-77 Do you mean to add a check like this?

hjk1030 avatar May 07 '24 15:05 hjk1030

Yes. But can you refactor the code? Don't use three functions.

ttt-77 avatar May 15 '24 06:05 ttt-77

@ttt-77 Is this better?

hjk1030 avatar May 15 '24 17:05 hjk1030

I expanded the outer two layers into loops to make it more readable, but I think retaining the innermost all() function won't affect readability much and simplifies the code.

hjk1030 avatar May 17 '24 03:05 hjk1030

@ttt-77 Could you please review this? I added the test mentioned by issue #55 to this PR as well. Since no real index is provided for the jackson dataset, I compared the inference count when using the random proxy score and the accurate proxy score generated from the ground truth result.

hjk1030 avatar May 26 '24 12:05 hjk1030

Can you split the new commit into another PR?

ttt-77 avatar May 27 '24 02:05 ttt-77