Tracey Yoshima

Results 72 comments of Tracey Yoshima

The BlockStatementTemplateGenerated does not check for `J.Parentheses` [here](https://github.com/openrewrite/rewrite/blob/main/rewrite-java/src/main/java/org/openrewrite/java/internal/template/BlockStatementTemplateGenerator.java#L138).

@thomaszub thanks for the report, we'll fix this as soon as we can!

Hi @Jonpez2 , thanks for all the information! I just want to add a comment so that anyone who is watching this issue knows we haven't forgotten about it. I...

Hi @Jonpez2, @tkvangorder has looked into the Jigsaw constraints and has a promising solution. Development of Java 17 support is in process.

Hi @yeikel, I spoke with the team and we won't be pursuing exclusions. Info on some of the complexities may be found [here](https://github.com/openrewrite/rewrite/issues/1731). We'd like to improve our style detection...

Ah, I see. > Without a mechanism to have exclusions, I'll have to revert the recipe application with each execution, and that's quite tedious and error prone to be honest...

> but it would be nice to have some way to automate its removal Ya, an internal recipe may take in a set of class FQNs like `AddRewriteSkip` and `RemoveRewriteSkip`....

This requires: https://github.com/openrewrite/rewrite/issues/533.

Partially, implemented in: https://github.com/openrewrite/rewrite/commit/22f06ffb030e65f5cb1749e7d455c2e59e6119b7. Currently, the recipe does not rename `all local variables`. The recipe does not rename fields that are local members of a class. since that would be...

> do you recall if there were any technical blockers with this item? Or has there just not been sufficient reason/demand to implement it? Hi @nmck257, there weren't any blockers...