Tracey Yoshima

Results 72 comments of Tracey Yoshima

Posterity, this issue is blocked by https://github.com/graphql-java/graphql-java/issues/2809.

> So the only downstream dependency that is preventing this is the graphql project? Yes. `checkstyle` was updated pretty quickly, but `graphql-java` has essentially stated it's not a priority.

Hi @jdelobel, just a friendly FYI - adding the language after ``` like ```java will add syntax to the snippets. :) `maybeAddImport` will check if the type is in use...

Hi @jdelobel, > But i dont think its a good practice. You're right 👍 Ideally, the import will be added with `maybeAddImport`, but the import is not added due to...

> imports said `"org.springframework.beans.factory.config.ConfigurableBeanFactor"` instead of `"org.springframework.beans.factory.config.ConfigurableBeanFactory"` @eddumelendez Thanks for catching the import typo! > Thanks its working! @jdelobel Happy to hear your recipe is working! I'll leave the issue...

> But the version declared in the dependancies mangaement is not uploaded in the pom.xml. Its working for others dependancies. Do you have any idea please? The `com.socgen.digital.spm.migrate.UpgradeJavaxServletApiVersion` recipe looks...

Hi @jdelobel, I plan to close this issue in a couple of days due to inactivity. Just making sure you're all set.

Hi @yeikel! I think there may be a typo in the `After`. The map would return the values from `Object#get()`, so the filter can only act on the mapped objects....

Hi @yeikel , an example of migrating a method invocation may be found here [rewrite-migrate-java](https://github.com/openrewrite/rewrite-migrate-java/blob/main/src/main/java/org/openrewrite/java/migrate/apache/commons/io/ApacheFileUtilsToJavaFiles.java). I think we don't have a generalized recipe yet, because it may require constructing imports...

I unassigned myself from the issue and closed the PR, because the recipe has a limited amount of applications and requires a lot of code to implement safely. It is...