Thomas Sandmann
Thomas Sandmann
It seems like the use of the `plotly::layout` function to set `width` and `height` parameters is being deprecated in plotly. For example, the following example leads to the warning shown...
I was wondering if there was a way to automatically add metadata when writing a pin, e.g. based on the class of the pinned object. For example, I work a...
Yes, the storage format would be Rds (or qs). Thanks a ton for the pointer to vetiver's wrapper code. That's super helpful, and I will explore that direction.
Thanks a lot for confirming that I am not overlooking this functionality (for now) @jayhesselberth, much appreciated!
Looking at how the versions to keep are identified in the https://github.com/rstudio/pins-r/blob/9e8c08123861eeef4853caa5ffd1970c9be0457e/R/pin_versions.R#L110 function, it seems that the versions are ordered by the `created` POSIX timestamp. At least on my system,...
Actually, is there a reason that the time stamp does not have second-level precision? It seems the `parse_8601_compact` and `parse_8601 ` functions don't contain the `%S` part of the format...
Interesting - as I was writing more of my unit tests, I noticed that the `pin_write` function behaves differently when it is run within or outside unit tests (of the...
After exploring how pins sets the `version` tag, I am wondering if perhaps the construction of `timestamp+partial hash` is a bit too risky. Maybe generating a [uuid](https://github.com/s-u/uuid) each time a...
## Review checklist for @tomsing1 ### Conflict of interest - [x] I confirm that I have read the [JOSS conflict of interest (COI) policy](https://github.com/openjournals/joss/blob/master/COI.md) and that: I have no COIs...
Great R package, @yiqunchen et al - and congratulations to getting it released on CRAN! @osorensen : looks great to me, I didn't spot any issues. My review is complete.