Tyrone Johnson

Results 37 issues of Tyrone Johnson

- Optimized modular system introduced - Staking contract refactored - split into modules - Tests updated to the new modular structure - Refactored stakeBySchedule - Restored function Staking.stakeWithApproval Note: original...

refactoring

it is not used and swap reverts if != 0

maintenance
medium priority

UPD: moved to #325 description we need to be able to rollback loan token logic fast in case of emergency implementation we need to store the previous logic contract per...

enhancement
high priority

the users' collateral for a margin trade is currently always held in the collateral currency we need to allow collateral to be held in the currency of the loan e.g....

enhancement
high priority

1. add swapsFeePercent on the protocol 2. add function setSwapsFeePercent() to SwapsExternal module 3. add deployment script which sets swapsFeePercent percent - set it 0.05% for testing 4. use swapsFeePercent...

high priority
refactoring

https://discord.com/channels/729675474665603133/746409782226976858/863033607333085214 need to wrap the functions in an intergation test add results verification

testing
maintenance
medium priority

https://github.com/DistributedCollective/Sovryn-smart-contracts/pull/311 as discussed primarily with @smbsp e.g. in _setTarget(this.swapExternal.selector, target); this.swapExternal.selector is replaced for this.swapExternal.selector^this.xor.selector (which should be a constant - ) in all modules that will lead to calling...

medium priority
refactoring

Task discussion - https://github.com/DistributedCollective/Sovryn-tasks-discussions/discussions/8 Implement solidity contracts functionality for Sovryn Treasury Dashboard Repo: https://github.com/DistributedCollective/Sovryn-Treasury-Dashboard * details to be added

enhancement
high priority

currently users can only increase their margin amount they need also to have an option of increasing their leverage

enhancement
high priority

medium priority
refactoring