Tyrone Johnson
Tyrone Johnson
> Looks good! The modules make sense, documentation is clear. There are only a few things I noticed. > > * The stakeBySchedule function was not refactored as expected (details...
@cwsnt pls see the Description of this ticket https://sovryn.atlassian.net/browse/SOV-1044 to fix the governor actions qty excess issue
Pls see the latest inline comments (conversations)
lgtm but for unresolved merge conflicts pls resolve
where is the release note? why is it in the review state in the github project?
> > > mission accomplished: https://github.com/jjmr007/RSK_debug_traceTransaction needs to be published in wiki
reentrancy guards are agreed not to be removed
this could be useful in the future, hence leaving it open