Surya!
Yes, I have also faced this issue. This is my next refactoring target after PR #2019. I hope it is good with you, @christophfroehlich.
I also think implementation is correct @kumar-sanjeeev, But if implementation is correct then, why are we failing tests? Overall, I think some tests need to be updated, but this is...
Phenomenal work, @kumar-sanjeeev. And I'm very glad you completed this, and now this is ready for a review. Good luck for ahead!
Yes, tricycle controller's odometer hasn't been updated, as I see it.
Of course then, so at first I will focus on refactoring and feature addition in following order, 1. Refactoring of joint_trajectory/include directory 2. Refactoring of joint_trajectory/src directory 3. Feature addition,...
After PR #2019 is merged. I'll focus on tolerances.hpp. **Future plan:** Refactoring of tolerances.hpp Current Progress: - [x] interpolation_methods.hpp - [ ] tolerances.hpp - [ ] trajectory.hpp & .cpp -...
Ok, I'll address all you questions one by one. > How do velocity constraints play together with stopped_velocity_tolerance? This is not clear from the parameter descriptions. I'll do it!! >...
I've added both parameters for the __map_joints. Now both trajectory and goal are either struct(new) or double(old). And I'll modify the implementation in source files, when I get free time,...
Yes, I also think so. We should wait few release syncs before cleaning it up. 👍