Andrew Haley
Andrew Haley
Please do not commit this until [9346](https://github.com/openjdk/jdk/pull/9346) is in.
> Hello, thank you for reviewing my patch. I have made the changes as suggested and waiting for the refactoring patch to be merged. I will then change my *ad...
> > Pointer-based representation is kept to avoid massive migration of users (from `->` to `.`) and to enable incremental migration on per-platform basis (pointer-based representation is assumed in shared...
Also: this patch is Linux-only. I'll ask for help from build experts to make the tests GCC-only; it's not clear to me how.
> It seems strange to me that the native library part is here: > > test/hotspot/jtreg/runtime/jni/TestDenormalFloat/libfast-math.c > > and the two test files are here: > > test/hotspot/jtreg/compiler/floatingpoint/TestDenormalDouble.java test/hotspot/jtreg/compiler/floatingpoint/TestDenormalFloat.java I...
> This appears to be a 10 year old bug in gcc. Have we ever had any issues reported because of this? That's what is so insidious about messing with...
> > Also: this patch is Linux-only. I'll ask for help from build experts to make the tests GCC-only; it's not clear to me how. > > @theRealAph We currently...
> We do not support gcc on macos, windows or aix, which leaves linux as the only gcc platform in the mainline (ports in separate repos will have to handle...
> So you want to provide this dlopen wrapper for other platforms as well? I'm not sure. It sounds to me like a Linux-only patch would do it, but I...