Andrew Haley
Andrew Haley
> Unfortunately, that didn't compile and I had make this change to get it to work: [stefank@d6bda1a](https://github.com/stefank/jdk/commit/d6bda1a25e297865fd6b5da21184273d8825b922) Done, thanks and sorry for the delay.
> I started to review the patch and was wondering if this could be simplify to something like this?: [stefank@f38c791](https://github.com/stefank/jdk/commit/f38c791793440b899ce6c4c9723470a5d4b18050) > > I tested this with this small section of...
> From the summary: > > > In addition, it would be useful to be able to static_assert different registers. > > As mentioned in [#16617 (comment)](https://github.com/openjdk/jdk/pull/16617#issuecomment-1807933886) this doesn't work...
Exhuming this one after a long time. Please review, thanks.
> > > I started to review the patch and was wondering if this could be simplify to something like this?: [stefank@f38c791](https://github.com/stefank/jdk/commit/f38c791793440b899ce6c4c9723470a5d4b18050) > > > > > > Sure, it...
> Just a code-style review. > > Question: could there be some sort of regression test for this, with different examples and edge cases? I have no idea, really. assert_different_registers...
> > > Just a code-style review. > > > Question: could there be some sort of regression test for this, with different examples and edge cases? > > >...
> Thank you @dean-long for the comment. I agree, tests are needed. Up to this point we have not had a separate formal tool to test encoding of x86. I...