tetrapod

Results 166 comments of tetrapod

I didn't do a whole review, but I skimmed and caught some typos. I also noticed no consistency of "Return" vs "Returns" or "Calculate" vs "Calculates" in the descriptions of...

I see a lot of places where style can be improved in a minor way, like styling literals as code and with a decimal marker for floats (e.g. `0.0` instead...

I started on a nitpicky style review but I think it would be better as a followup PR - making all the required changes is annoying as suggestions. It's a...

Yeah, now you're waiting on another review from clayjohn or someone else with shader-specific knowledge to do a high-level review including whatever other style nitpicks come up in that review,...

I did an in-depth review. Overall this looks great. I found a few factual and copy-paste errors, and made a lot of minor style changes. The changes are in a...

The rendered HTML is not the same (tested on Windows 10, Firefox, 100% browser zoom). Before the changes, the function names are gray, but after the changes the function names...

The docs was dark mode due to my Firefox configuration. I switched Firefox to light mode. Now this reStructuredText source from commit https://github.com/godotengine/godot-docs/commit/220fb2b85988899f5b2676bc61b6b1e5ba49efd6: ```reStructuredText .. _shader_func_textureProjGrad: .. rst-class:: classref-method |...

This closes https://github.com/godotengine/godot-docs/issues/5594 and https://github.com/godotengine/godot-docs/issues/9310. FYI I edited the description so it will auto-close the relevant issues.

And, finally merged. Thanks for this *monumental* improvement to the shader documentation, and thanks for your consistent work in response to reviews. For a first-time contribution, this is huge. And...

Thanks for contributing, and for sticking with the review process. However, I am inclined to agree with other reviewers that as-is, this doesn't seem like a great addition to the...