Thomas Bitonti

Ref: /org.eclipse.transformer/src/main/java/org/eclipse/transformer/TransformProperties.java // TODO: We might want to skip an update in a specific // case. A blank/empty update might be used to // encode this. if ( nameBuilder.length() !=...

Are USAGE and HELP command line return codes correct?

1

Ref: /org.eclipse.transformer.cli/src/main/java/org/eclipse/transformer/cli/TransformerCLI.java // TODO: Are the USAGE and HELP return codes correct? if ((getArgs().length == 0) || hasOption(AppOption.USAGE)) { usage(getSystemOut()); return logResult(ResultCode.SUCCESS_RC); } else if (hasOption(AppOption.HELP)) { help(getSystemOut()); return logResult(ResultCode.SUCCESS_RC);...

Ref: /org.eclipse.transformer/src/main/java/org/eclipse/transformer/action/impl/ZipActionImpl.java // TODO: The replication of the 'isDuplicate' checks, below, // indicates that the apply/record pattern is clumsy // and should be replaced.

Ref: /org.eclipse.transformer/src/main/java/org/eclipse/transformer/action/impl/DirectoryActionImpl.java // TODO: Add duplicate checking when --overwrite is not enabled.

Unify 'replacePackage' and 'replacePackages in the signature rule implementation

3

Ref: /org.eclipse.transformer/src/main/java/org/eclipse/transformer/action/impl/SelectionRuleImpl.java // TODO: Unify the implementations of 'replacePackages' // and 'replacePackage'. private String replacePackages(String text, Map renames) {

Ref: /org.eclipse.transformer/src/main/java/org/eclipse/transformer/action/impl/ZipActionImpl.java // TODO: // // Not sure about whether these time values should be set. // Does changing the entry name invalidate the prior values? // Also, setting these...

Ref: /org.eclipse.transformer/src/main/java/org/eclipse/transformer/Transformer.java // TODO: Should EAR add the other standard actions?

Ref: /org.eclipse.transformer/src/main/java/org/eclipse/transformer/Transformer.java // TODO: Need a better way to handle errors. // // (1) Having element actions throw an exception while // having container actions count failures makes for //...

Additional review is needed of these test changes: Ref: /org.eclipse.transformer/src/test/java/transformer/test/TestTransformClass.java // TODO: // // Previously, only [5] direct replacements were made. // // With the direct string update modifications, [14]...

TransformerCLI logging cleanup

2

Ref: /org.eclipse.transformer.cli/src/main/java/org/eclipse/transformer/cli/TransformerCLI.java // TODO: Usual command line usage puts SysOut and SysErr together, which // results in the properties writing out twice. private void preInitDisplay(String message) { PrintStream useSysOut =...