syang0

Results 15 comments of syang0

I'll update the README more formally at a later point, but informally, we expect the _amortized_ performance of the two to be pretty much the same. Here "_amortized_" means you've...

Hi thingsareright, Unfortunately, the project only supports Linux right now, and I've updated the README.md to reflect this. However, I believe the only incompatibilities with Windows are NanoLog's usage of...

Hi Roman-Koshelev, The decision was made long ago, so I may not remember all the details. However, I believe posix AIO was originally chosen because it was more convenient at...

Hi xgdgsc, I'll hold off on accepting this patch until we have #29 figured out =) Best Regards, Stephen Yang

Bjmiao is right, currently the background thread is built into NanoLog’s architecture. I did briefly experiment with the second option they suggested, but the patch is outdated now and no...

Hm... I think the answer depends on which version of NanoLog you intend to modify. It should be fairly simple to do in C++17, and a bit harder in Preprocessor...

Ah! That is true, C++17 NanoLog relies on the GNU format __attribute__ to check for errors. That is a complication I did not foresee. Hm... I think it is doable...

Hello xgdgsc, Your patch is still missing headers. Please add an integration test for your install and ensure it works before submitting another pull request. Your integration test should additionally...

Hey xgdgsc, I'm not sure if you've finished the revisions, but looking at the changes, there appears to be two problems still. 1. The integration test is failing because I...

Hi xgdgsc, There is still one more problem with the patch. Your test application still does not completely test the installed headers. More specifically, it builds sample's `main.o` with the...