NanoLog add install

Not sure if you think the include folder name is OK.

Jun 19 '20 10:06 xgdgsc

Hello xgdgsc,

Your patch is still missing headers. Please add an integration test for your install and ensure it works before submitting another pull request. Your integration test should additionally be added as part of the GitHub workflow to ensure it runs upon the pull request as well.

Best Regards, Stephen Yang

Jun 19 '20 21:06 syang0

Hey xgdgsc,

I'm not sure if you've finished the revisions, but looking at the changes, there appears to be two problems still.

The integration test is failing because I think you need sudo to install the library to /usr/local/lib and
Your integration tests don't properly test the installed library. More specifically, the last step builds the sample application by invoking make in the sample subdirectory. This build command will actually include the headers and library from the runtime directory rather than pulling it from the system folders.

Best Regards, Stephen Yang

Jun 23 '20 22:06 syang0

Hi xgdgsc,

There is still one more problem with the patch. Your test application still does not completely test the installed headers. More specifically, it builds sample's main.o with the default rules, which would link with NanoLog/runtime/*.h headers rather than the system headers.

Best Regards, Stephen Yang

Jul 01 '20 22:07 syang0