Chris Sweeney

Results 48 comments of Chris Sweeney

I should mention that this was only an issue for me when using the TrustRegionPreprocessor, as [this line](https://github.com/ceres-solver/ceres-solver/blob/master/internal/ceres/trust_region_preprocessor.cc#L370) is not reached if any of the preprocessing fails. In my case,...

Did you try using incremetal Sfm?

Could you describe what this is actually doing? I'd be happy to accept a pull request if adding this feature makes sense. The only worry I have is backwards compatibility...

You could be right. Is it possible to add a unit rest which shows verifies your suggestion? Then I'd be happy to accept a pull request with the fix.

Regarding jenkins-traub I actually do have a state of the art implementation of this algorithm (rpoly++) but overall I found the matrix approach to give more stable results consistently, though...

Happy to accept a PR if you were able to fix this bug :)

These are gflags definitions of command line arguments On Thu, Feb 20, 2020, 2:31 AM kyuhyoung wrote: > Where are things such as "FLAGS" such as "FLAGS_calibration_file" are > defined...

As you can see from the command, you've provided an --output_reconstruction flag where the colored reconstruction will write to. I don't know why you assume that an app called colorize_reconstruction...

I'll try to review and pull these changes in soon. Sorry for the delay! Things have been very busy lately.

Could you move the second commit to a different PR? I'm still debating if the first one should be pulled into the main repo... it adds a lot of ugliness...