諏訪原慶斗
諏訪原慶斗
## Changes Improvements have been made to the WriteHeader and Flush methods of response.go. ## 1. **Check logger existence with ``WriteHeader``**: `r.echo` and `r.echo.Logger.Warn` are not `nil` before calling `r.echo.Logger.Warn`....
## Overview The following improvements have been made to the `WriteHeader` and `Flush` methods of `response.go`: 1.**Check for logger presence in ``WriteHeader``**: Before calling `r.echo. Make sure that `r.echo` and...
## Changes Changed the PANIC message to be more specific. ## Improved debugging efficiency. When Flush is not supported, it is clear which ResponseWriter is the culprit, speeding problem identification...
## Current Issues The Response.Flush() method in echo/response.go causes a panic if the http.ResponseWriter it wraps does not support the http.Flusher interface. The current panic message is “response writer flushing...
## Problem Both the `ValidateFlagGroups` and `enforceFlagGroupsForCompletion` functions currently contain duplicated logic for determining which flags have been set in each flag group. ## Fix This redundancy has been eliminated...
I would suggest some improvements to further improve robustness and readability ##Proposal ### Improve robustness of joinPaths function Currently, the joinPaths function uses a homebrew lastChar function to determine if...
Sorry, I accidentally deleted the local directory I forked from, so I created a new Pull Request! ## Changes Changed the PANIC message to be more specific. `Tests related to...
## Proposal ### 1. Error handling when reading request body: Currently, errors in io.ReadAll(c.Request().Body) are ignored. If the read fails, subsequent handlers may receive an incomplete body, causing unexpected behavior....
## Problem The `matchSubdomain` function incorrectly returns `false` for exact domain matches without wildcards—for example, `http://example.com` vs. `http://example.com`. ## Cause Even if all parts match during iteration, the function still...
## Improved readability of HSTS header construction logic Currently, the logic for constructing the value of the Strict-Transport-Security (HSTS) header is to nest fmt.Sprintf and concatenate the strings. I believe...