echo icon indicating copy to clipboard operation
echo copied to clipboard

Fix matchSubdomain function to correctly handle exact domain matches

Open suwakei opened this issue 6 months ago • 4 comments

Problem

The matchSubdomain function incorrectly returns false for exact domain matches without wildcards—for example, http://example.com vs. http://example.com.

Cause

Even if all parts match during iteration, the function still returns false at the end.

Fix

After the loop, if all parts match and the number of parts is equal between the pattern and the domain, it should return true—i.e., treat it as an exact match.

This PR adds that check.

suwakei avatar Jul 14 '25 05:07 suwakei

Hi! Just following up to see if there's anything I can improve in this PR 🙇

suwakei avatar Jul 16 '25 04:07 suwakei

My two cents: I think the only think is missed the specific test for that case in util_test.go

FrancoTampieri avatar Jul 16 '25 05:07 FrancoTampieri

I added specific unit test

suwakei avatar Jul 16 '25 06:07 suwakei

Hi maintainers 👋 Just following up on this PR — happy to make any changes if needed. Please let me know if there's anything blocking review. Thanks!

suwakei avatar Jul 29 '25 16:07 suwakei