sovdee

Results 390 comments of sovdee

Resetting movement speed attribute sets the value incorrectly

Turns out there's a separate method to access the default values which we can use to improve this.

Ignore ExprConfig and ExprScript tests when not using gradlew clean or dev mode is enabled

I don't like ignoring tests because they modify things. I think the answer to this is to just run gradle clean instead of just not running some tests.

Potion Effects should follow vanilla behavior by default

I'm not sure what I did to get 15 seconds of speed 2 with the `replacing the existing effect` version originally, but I tested the code you used and got...

Test parallel test actions

2 parallel tasks, with java 17 tests

Test parallel test actions

2 parallel tasks, 2.14 tests (1.21+)

Converting bases, color hex codes, and ranged function parameters

Test failure is due to odd interaction between runtime error and simplification I'll add a fourth PR to this to allow turning runtime errors during simplification into parsing errors via...

Loops cause havoc when determining possible delays in code

Discussion has pointed out Delay.isDelayed() as a possible help, but that has a bug of its own, since it's entirely event-based and doesn't consider different structures separately: ``` on jump:...

Loops cause havoc when determining possible delays in code

This issue does not have a pr fixing it yet. #7777 is a stepping stone to fixing it, but not a fix. Do not mark as PR Available.

Async thread script loading lines of errors are out of order

Please attach logs of an example of this bug as well as a full readout of /sk info.

event-item doesn't exist in on bucket empty

This is due to the event-block being converted to an item, but WATER and LAVA not having item counterparts. The issue is more that the bucket events are sorely outdated,...