sovdee
sovdee
Marking as draft as it's not my priority right now. Please comment if you would like to take over/make your own version of this pr.
Closing due to inactivity
A few concerns here - the tests hardly ever test that the copy actually copied the orginal. Except for the vector, they don't check if the copies are actually separate....
> Truthfully, I wish you would've voiced these concerns when we were discussing it in Discord yesterday. Honestly I didn't have these concerns until I saw the feature as a...
> this also opens up to “addon name spoofing” where this data can be manipulated and misused to display inappropriate content. This isn't a worry imo. Bstats already provides filtering...
Do you intend to continue working on this?
I'm concerned that this rotate effect will add a lot of ambiguity to the existing rotate effect for displays, vectors, and quaternions. I'd like to see the two integrated if...
> > > I'm concerned that this rotate effect will add a lot of ambiguity to the existing rotate effect for displays, vectors, and quaternions. I'd like to see the...
> > I understand, but the point of my comment is that we shouldn't have two methods of rotating things, one that one works for x and one that only...
Yeah, afaik this isn't our issue unfortunately