Jakub Kłobus comments

Results 19 comments of


                                            Jakub Kłobus

Recommend Placing Inside ApolloProvider?

Hi @geirman. Good point! It doesn't matter where you put our `ThemeProvider` because it only shares a context. But it could matter for other Providers and it depends on their...

Grid

We probably don't need it

Support numeric keyboard for zip codes

Hi @ktamir. I'm afraid we cannot implement this without changing stripe-ios and stripe-android libraries. @davidme-stripe is specifying the keyboard type for zip code somewhere in the backlog?

check if the content and the wrapper exists before computing the sizes

@alexnaiman thanks for your work. I left to minor comments

Mutating 'style' is deprecated warning

Hi, sorry for long response... I've pushed new version (v0.4.2) with @StTraft fix. @bcbirkhauser can you confirm that it fixes your issue.

Migrating to the present

I already started reimplementation (v1.0.0). Stay tuned!

Bad performance with more than 50 element

Hi and thanks, I know that `ScrrollArea` has a lot of performance issues. But I have not found any good solution to fix those issues yet. (BTW @tkh44, your's ideas...

Debounce and throttle event handlers

I need to think about this change because I've never used debounce nor throttle. Is it really improves scrollbar performance?

Add customizable classnames for scrollbar and scrollabar-container

Hey, I'm sorry. @avanes please see my comment in PR #88

Scroll up/down arrows support

Hi, As 'up/dow scroll arrows' you mean: ![scroll arrow](https://cloud.githubusercontent.com/assets/1694993/12287771/7bae0c86-b9cf-11e5-8a2c-6648edaf7dd6.PNG)