reactScrollbar icon indicating copy to clipboard operation
reactScrollbar copied to clipboard

Mutating 'style' is deprecated warning

Open bcbirkhauser opened this issue 9 years ago • 3 comments

Occassionaly this happens when the scrollarea re-renders. I know react-motion has an issue with NaN in the style object, which seems to be the cause of this issue. Once this error occurs, the scrollarea is broken and will not scroll.

warning.js:45 Warning:divwas passed a style object that has previously been mutated. Mutatingstyleis deprecated. Consider cloning it beforehand. Check therenderofMotion. Previous style: {height: 194.75812743823147, marginTop: NaN}. Mutated style: {height: 194.75812743823147, marginTop: NaN}.warning @ warning.js:45checkAndWarnForMutatedStyle @ ReactDOMComponent.js:186ReactDOMComponent.Mixin._updateDOMProperties @ ReactDOMComponent.js:770ReactDOMComponent.Mixin.updateComponent @ ReactDOMComponent.js:699ReactDOMComponent.Mixin.receiveComponent @ ReactDOMComponent.js:645ReactReconciler.receiveComponent @ ReactReconciler.js:87ReactChildReconciler.updateChildren @ ReactChildReconciler.js:84ReactMultiChild.Mixin._reconcilerUpdateChildren @ ReactMultiChild.js:216ReactMultiChild.Mixin._updateChildren @ ReactMultiChild.js:351ReactMultiChild.Mixin.updateChildren @ ReactMultiChild.js:326ReactDOMComponent.Mixin._updateDOMChildren @ ReactDOMComponent.js:871ReactDOMComponent.Mixin.updateComponent @ ReactDOMComponent.js:700ReactDOMComponent.Mixin.receiveComponent @ ReactDOMComponent.js:645ReactReconciler.receiveComponent @ ReactReconciler.js:87ReactCompositeComponentMixin._updateRenderedComponent @ ReactCompositeComponent.js:562ReactCompositeComponentMixin._performComponentUpdate @ ReactCompositeComponent.js:544ReactCompositeComponentMixin.updateComponent @ ReactCompositeComponent.js:473ReactCompositeComponent_updateComponent @ ReactPerf.js:66ReactCompositeComponentMixin.receiveComponent @ ReactCompositeComponent.js:405ReactReconciler.receiveComponent @ ReactReconciler.js:87ReactCompositeComponentMixin._updateRenderedComponent @ ReactCompositeComponent.js:562ReactCompositeComponentMixin._performComponentUpdate @ ReactCompositeComponent.js:544ReactCompositeComponentMixin.updateComponent @ ReactCompositeComponent.js:473ReactCompositeComponent_updateComponent @ ReactPerf.js:66ReactCompositeComponentMixin.performUpdateIfNecessary @ ReactCompositeComponent.js:421ReactReconciler.performUpdateIfNecessary @ ReactReconciler.js:102runBatchedUpdates @ ReactUpdates.js:129Mixin.perform @ Transaction.js:136Mixin.perform @ Transaction.js:136assign.perform @ ReactUpdates.js:86flushBatchedUpdates @ ReactUpdates.js:147ReactUpdates_flushBatchedUpdates @ ReactPerf.js:66Mixin.closeAll @ Transaction.js:202Mixin.perform @ Transaction.js:149ReactDefaultBatchingStrategy.batchedUpdates @ ReactDefaultBatchingStrategy.js:62enqueueUpdate @ ReactUpdates.js:176enqueueUpdate @ ReactUpdateQueue.js:24ReactUpdateQueue.enqueueSetState @ ReactUpdateQueue.js:190ReactComponent.setState @ ReactComponent.js:65i.value @ scrollArea.js:1

bcbirkhauser avatar Apr 27 '16 19:04 bcbirkhauser

I can replicate this issue anytime an element goes over the scroll area. For instance, in my app I have some tooltips and overlays. If any of those appear, and you click on them, then the scroll area will throw this error.

bcbirkhauser avatar Apr 29 '16 18:04 bcbirkhauser

maybe you can try my fix on this. I've encountered the same issue as you before. prevent from undefined value for deltaX and deltaY

StTraft avatar Apr 30 '16 10:04 StTraft

Hi, sorry for long response... I've pushed new version (v0.4.2) with @StTraft fix. @bcbirkhauser can you confirm that it fixes your issue.

souhe avatar Sep 29 '16 09:09 souhe