Stig Oskar Ofstad comments

Results 20 comments of


                                            Stig Oskar Ofstad

feat: fix functions names & related terminology to be imperative

Thanks for the PR, I have nothing to add beyond Sebastians review. Let's fixed that, and it's ready for merge :slightly_smiling_face:

💡 [Feature] - Ability to send custom headers in the authorization, token requests

Hi @videate-miguel I'm not opposed to allowing for extra headers in general, but the example you give is exactly why I'm not sure it's a good idea. Sending a custom...

💡 [Feature] - Ability to send custom headers in the authorization, token requests

All right, I don't like this. But since all the defaults are secure, the library should not limit anyone in doing custom/unsafe stuff if they know what they are doing....

Bug: rename "login" to "logIn"

Your right! "Logout" is not a verb. Thanks for pointing this out :slightly_smiling_face: Agreed we should fix this (with backwards compatibility), so any PR is welcome.

feat: error boundary for react

This is not so much a bug report, as a suggestion to add an example of an error boundary. Which is often needed in most apps.

feat: Replace config.state with callback

Thanks for the PR @nrosenwald! Have had something like this in mind as well :) Just thinking, there should be no reason for the user to provide this function, if...

fix: fetch tokens when loginInProgress is false

Hi @CodingDaria, thank you for the PR and for raising the issue. I will make some time to look at this a bit closer, and test some stuff. But the...

fix: fetch tokens when loginInProgress is false

Closing this for reasons state in above comment.

[Question] Slient refresh in background

Refresh happens whenever as long as a tab is open (also in the background), that's right. How do you define "user is idle"? What do you mean by "session idle"?...

[Question] Slient refresh in background

I think this is a reasonable request. It hardens the system, without necessarily adding much new complexity. The biggest risk of client-side token storage, IS XSS-vulnerabilities, leading to token/refresh-token extraction....