react-oauth2-pkce icon indicating copy to clipboard operation
react-oauth2-pkce copied to clipboard

Bug: rename "login" to "logIn"

Open getsnoopy opened this issue 2 years ago • 7 comments

Function names should be in the imperative form, which means they should be verbs. Since the verb for the action is a compound verb, it's two words: log and in. In camelCase, this would be logIn (just as it is with its complementary function logOut), not login (which is the noun form).

getsnoopy avatar Sep 19 '23 22:09 getsnoopy

Your right! "Logout" is not a verb. Thanks for pointing this out :slightly_smiling_face:

Agreed we should fix this (with backwards compatibility), so any PR is welcome.

soofstad avatar Sep 26 '23 13:09 soofstad

Stale issue message

github-actions[bot] avatar Nov 25 '23 20:11 github-actions[bot]

Sure, I'll get going on a PR for this.

getsnoopy avatar Nov 25 '23 23:11 getsnoopy

Stale issue message

github-actions[bot] avatar Jan 26 '24 20:01 github-actions[bot]

@getsnoopy Did you start working on a little PR for this?

sebastianvitterso avatar Jan 29 '24 07:01 sebastianvitterso

@sebastianvitterso I haven't yet; I'll probably get to it next week.

getsnoopy avatar Jan 30 '24 02:01 getsnoopy

Stale issue message

github-actions[bot] avatar Mar 30 '24 20:03 github-actions[bot]