Muhammad Aqdas
Muhammad Aqdas
Ran into a few issues with linting and forgot to pass the `disableSelfView` bool to the video popup. Should be fine now.
Missed one lint due to expecting the linter to ignore the line. Fixed.
Made the pull request branch up-to-date with the main branch.
Hello! I'd like to try and tackle this issue! I see you mentioned Makepad's limitations there, particularly regarding wrapping. Is there any update on that from the Makepad team? Of...
https://github.com/user-attachments/assets/be783d62-ecd3-4de1-a7e7-f92894cab9f8 Hi @alanpoon! This PR looks wonderful! I checked it out after your request to do so on #395 and found a few issues. The attached video walks through them...
> Thanks, I wasn't sure if you were ready for me to review this but I left a few comments anyway. > > Regarding clean encapsulation of the JTB button...
So a few things The logic I'm thinking of running with is that whenever there's a new message and the user isn't at the bottom, an indicator should be shown....
> Yep! That's all perfectly accurate. Great then! I spent some time trying to refine the implementation of the logic but honestly what my branch currently has on github is...
> sorry, so should I go ahead and review/merge this in, or am I waiting for more changes from you or from a different PR first? I think this should...
Okay #86 is apparently done, and an adjustment on it is ready to be approved by the author of the same PR. As soon as that's done, this here can...