Searching messages in a room (not encrypted)

[alanpoon]

https://github.com/user-attachments/assets/97831448-af17-46ac-97b2-2adf171d232a

[smarizvi110]

https://github.com/user-attachments/assets/be783d62-ecd3-4de1-a7e7-f92894cab9f8

Hi @alanpoon! This PR looks wonderful! I checked it out after your request to do so on #395 and found a few issues. The attached video walks through them (please skip to 0:19)

Firstly, the initial start up sequence looks very different from what the program looks like when cloned from the original repo's main branch. Secondly, several icons seem to be missing too. I checked out the commits ahead of your branch on project-robius/robrix:main and it doesn't seem like there was any file changed that would lead to this issue, but I could be wrong on this.

Third, the search feature itself seems to work! The only problem is that when you attempt to search all rooms while initiating a search in an encrypted room, it does not seem to search in any available unencrypted rooms either and simply tells me that searching unencrypted rooms is currently not supported. Furthermore, the little notification that tells me this seems to never go away, and just stays there in the top right corner. Perhaps that should be tweaked to disappear in a few seconds?

One last thing is that the mermaid diagram you attached to the PR here makes sense, but I don't quite understand why there are 4 edges coming out of the Check Room Encryption node. Shouldn't there just be 2, one for encrypted room searching flow and one for unencrypted room search flow? If I'm misunderstanding something, please do let me know!

For reference, the second video shows what Robrix looks like currently on project-robius/robrix:main where the icons are not missing and the startup screen looks a little more user-friendly.

Please note that in both cases, I gave Robrix my credentials through the CLI when using cargo run.

https://github.com/user-attachments/assets/ec140129-71e4-4371-aaa1-71013a587888

Thank you!

[alanpoon]

MUTED_2025-05-22.18-27-24.mp4

Hi @alanpoon! This PR looks wonderful! I checked it out after your request to do so on #395 and found a few issues. The attached video walks through them (please skip to 0:19)

Firstly, the initial start up sequence looks very different from what the program looks like when cloned from the original repo's main branch. Secondly, several icons seem to be missing too. I checked out the commits ahead of your branch on project-robius/robrix:main and it doesn't seem like there was any file changed that would lead to this issue, but I could be wrong on this.

Third, the search feature itself seems to work! The only problem is that when you attempt to search all rooms while initiating a search in an encrypted room, it does not seem to search in any available unencrypted rooms either and simply tells me that searching unencrypted rooms is currently not supported. Furthermore, the little notification that tells me this seems to never go away, and just stays there in the top right corner. Perhaps that should be tweaked to disappear in a few seconds?

One last thing is that the mermaid diagram you attached to the PR here makes sense, but I don't quite understand why there are 4 edges coming out of the Check Room Encryption node. Shouldn't there just be 2, one for encrypted room searching flow and one for unencrypted room search flow? If I'm misunderstanding something, please do let me know!

For reference, the second video shows what Robrix looks like currently on project-robius/robrix:main where the icons are not missing and the startup screen looks a little more user-friendly.

Please note that in both cases, I gave Robrix my credentials through the CLI when using cargo run.

2025-05-22.18-30-28.mp4

Thank you!

Thank you for testing. Unfortunately, I cannot replicate the missing icon issues even after cloning my branch. I have fixed the issue of not be able to search all rooms while initiating a search in an encrypted room. There's supposed to be a close button on the top right of the popup which could be missing due to missing icon issues. I have also fixed the mermaid diagram.

[ZhangHanDong]

There are currently some issues with the testing.

1. When I click the jump button for Luo’s message from 2025-01-16 on the right, if the earlier messages haven’t been loaded yet, a popup appears as shown in the image. Normally, it should automatically scroll the popup to match the message, right?

2. Another issue—not exactly a bug—is that it takes several seconds to scroll to the matched message after jumping. Is there any way to optimize this?

[alanpoon]

There are currently some issues with the testing.

1. When I click the jump button for Luo’s message from 2025-01-16 on the right, if the earlier messages haven’t been loaded yet, a popup appears as shown in the image. Normally, it should automatically scroll the popup to match the message, right?

2. Another issue—not exactly a bug—is that it takes several seconds to scroll to the matched message after jumping. Is there any way to optimize this?

1. Currently, I am mirroring the jump to related message logic. Try and reply to an early message, right click to jump to related message. You will also encounter this Modal popup error. I have raised this issue: https://github.com/project-robius/robrix/issues/561.
2. I have sped up the scroll speed.

[alanpoon]

@smarizvi110 Hi, Could you also help to test this search feature? Search result is now being displayed at the right drawer.