Joe

Results 11 comments of Joe

@seratch thank you for confirming the behaviour. I do think this would be a great enhancement, especially as sometimes we need to query external services or do relatively heavy validation

Clarification Request: Please advise. I did my best before asking, but I don't understand what the PR checks are complaining about or how to fix it. Update: I figured it...

I agree this would be very useful. A minimal change to support it could be to modify the grid endpoint to support returning as JSON format rather than rendering the...

Tentative solution is updating to 17.0.11.9.1, although at a glance I don't see any obvious code changes that might have addressed the issue.

> Hi @sigJoe thanks for contributing, would like to hear more opinion on the change of behavior here > > > If someone is relying on the previous behaviour where...

After thinking about it further, I removed the merging of samconfig with CLI parameter overrides as probably deserves further discussion

To recap: I changed the syntax that failed the Python3.9 tests and removed the merging of parameters that caused that integration test to fail (can re-add if necessary but should...

Sorry about that - I'm not sure how I missed those other failing tests.

Hey I just wanted to follow up and see if there's anything you guys need from me on this or if you're still reviewing. I think it's a pretty valuable...

Hi @roger-zhangg. With apologies, I accidentally reset your approval when I clicked the `Commit suggestion` button for your suggested change. Can you kindly re-approve? Thanks