bolt-python icon indicating copy to clipboard operation
bolt-python copied to clipboard

Conditional Lazy Listener?

Open sigJoe opened this issue 4 years ago • 2 comments

Is there a way to make it so that the lazy function triggers conditionally based on the ack response?

For example, I want my ack to do parameter validation and potentially reject the request. Right now, my solution is to have the lazy function run the same parameter validation as the ack function, but it seems a bit wasteful. I'd much rather the lazy function not get triggered at all in the scenario where the ack function returns errors to the user.

Reproducible in:

The slack_bolt version

slack-bolt==1.9.1

Python runtime version

Python 3.8.12

OS info

ProductName:    macOS
ProductVersion: 11.5.2
BuildVersion:   20G95
Darwin Kernel Version 20.6.0: Wed Jun 23 00:26:31 PDT 2021; root:xnu-7195.141.2~5/RELEASE_X86_64

Steps to reproduce:

Run something like this:

def validate_the_stuff(ack, view):
    #errors = validate_inputs(view)
    errors = { "environment-select-block": "Nope" }
    if len(errors) > 0:
        ack(response_action="errors", errors=errors)
        return False
    else:
        ack(response_action="clear")

def do_the_thing(view):
    logging.error("You should not get this far")

app.view_submission('environment_select_submit')(
    ack=validate_the_stuff,
    lazy=[do_the_thing]
)

Expected result:

Don't do the thing if validation fails.

Actual result:

Does the thing even if validation fails.

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

sigJoe avatar Oct 01 '21 15:10 sigJoe

Hi @SigniantJoe, thanks for writing in!

Unfortunately, there is no way to run lazy listeners based on the ack listener behavior. the current recommendation for your use case at this moment is to have the same validation in the beginning of the lazy listeners.

With that being said, we may consider adding a new configuration / mechanism to support this use case in a better way.

seratch avatar Oct 04 '21 01:10 seratch

@seratch thank you for confirming the behaviour. I do think this would be a great enhancement, especially as sometimes we need to query external services or do relatively heavy validation

sigJoe avatar Oct 04 '21 16:10 sigJoe