ibcswap

ibcswap copied to clipboard

Need Error Handling for SendCoinsFromAccountToModule Function

2

#### Credit to : [HelloBloc](https://twitter.com/MaLucasBC) @liangping ## Description In the following code content, the error handling of `x.bankKeeper.SendCoins` is missing, which will result in a malicious `user` being able to...

slendermaan

soring323

amityadav0

## Intro In the following code content, the error handling of x.bankKeeper.SendCoins is missing, which will result in a malicious user being able to set the status without cost. https://github.com/sideprotocol/ibcswap/blob/3aa2b1b3b8c044902b9f845ae2c705ccc7f83480/modules/apps/100-atomic-swap/keeper/msg_server.go#L122...

Hellobloc

We need to implement a demo, following the spec https://github.com/liangping/ibc/tree/interchain-swap/spec/app/ics-101-interchain-swap Tasks: - [x] Create .proto file according the definitions in ics-101-interchain-swap. - [x] Generate go files from proto using `buf`...

liangping

We need to implement a demo, following the spec https://github.com/liangping/ibc/tree/atomic-swap/spec/app/ics-100-atomic-swap Tasks: - [x] Create .proto file according the definitions in ics-100-atomic-swap. - [x] Generate go files from proto using `buf`...

liangping

Things to be done: - [x] 1. Setup relayer. - [x] 2. add ICS restful api to Swagger UI. - [x] 3. Reset Blockscout. - [ ] 4. Use CI/CD...

liangping