Incompletely Fixed Error Handling that can Lead to n-No-cost Minting

Open Hellobloc opened this issue 2 years ago • 0 comments

Intro

In the following code content, the error handling of x.bankKeeper.SendCoins is missing, which will result in a malicious user being able to set the status without cost. https://github.com/sideprotocol/ibcswap/blob/3aa2b1b3b8c044902b9f845ae2c705ccc7f83480/modules/apps/100-atomic-swap/keeper/msg_server.go#L122

REF: https://github.com/sideprotocol/ibcswap/issues/8

Jul 30 '23 17:07 Hellobloc