Simon De Kock
Simon De Kock
Hi @aulemahal I just moved the files over to a local system to give you some examples; indeed, I get the correct output now. I need to check if this...
@RubenImhoff I went trough the whole code to see what was unclear for me. I will already paste my findings here and maybe we can discuss later today. Ill first...
For all of these, I could not find the names in the nowcast steps but it is really hard to see the variables through the forest :) . I also...
I agree this is the most elegant solution but maybe we should tackle that problem after name changes and changing the monolith into something more readable?
My work today so the refactoring can be done in the future; things like splitting up the code into more modular functions or making a class can be added after...
I just went trough the code to try and refactor it. A version **This is just a proof of concept** is now pushed to try and show my suggestions (however...
# Refactoring Plan | Part in Code | Suggested Name | Extra Info/Recommendations | |-----------------------------------------|------------------------------------------|-------------------------------------------------------------------| | Everything from start till just before #1 | `preprocessing` | Check if all variables...
@RubenImhoff @dnerini would now be a good time to refactor the code in steps blending and nowcasting? I have talked to @mats-knmi about how this would be integrated in the...
@dnerini just to confirm if this would be okay. I was planning to refactor this code to a class due to all the variables. Does this conform to the pysteps...
@mats-knmi Will do! I will probably only start somewhere later this week. The teaching season is once again upon me so first need to make sure I am ready on...