Simon De Kock

Results 26 comments of Simon De Kock

@mats-knmi I will start this afternoon with the re-factoring. Will start with the nowcast steps to have a template and then look at the blending steps. Ill add you as...

So I started today but I have a general question regarding the _check_inputs function. This is used to check some of the inputs put others are then checked in the...

I have a question about the Codacy Static Code Analysis. It sais the method _check_inputs is to complex while this has barely been touched since the last version, I moved...

@mats-knmi @RubenImhoff Could you take a look at this and give feedback? That way I can go on to the blending version. I don't want to start working on that...

> Hi @sidekock, super nice work! Thanks a lot for picking up this tremendous task. I like that we use a class now, it is much cleaner this way. >...

> @sidekock Should this be merged? Let me use the feedback of Mats. I will contact you once it is ready to be merged.

@mats-knmi could you look through the changes to give some feedback? I will look at the 'private' variables next week if I have time. In general, I think this approach...

> Looks good, I added 2 small comments on the type hinting, but other than that I think this makes it a lot nicer indeed. Regarding the private discussion: Every...

@dnerini the Static code analysis is complaining again because I changed the name of the method "__check_inputs". Would it be possible to disable this once more? That way, all tests...

> @sidekock I resolved all my comments that are fully resolved now, I left 2 open, since those are not fully resolved yet. > > I think the docstring comment...